Fixed comment (forgot to fix it in the last commit)
authorPavol Marko <pavolmarko@gmail.com>
Fri Oct 12 19:19:17 2007 +0000 (2007-10-12)
changeset 41359bbed37595c
parent 412 43098e572d24
child 414 383383ec840c
Fixed comment (forgot to fix it in the last commit)
sourcehook/generate/sourcehook.h
sourcehook/generate/sourcehook.hxx
sourcehook/sourcehook.h
     1.1 --- a/sourcehook/generate/sourcehook.h	Fri Oct 12 19:17:52 2007 +0000
     1.2 +++ b/sourcehook/generate/sourcehook.h	Fri Oct 12 19:19:17 2007 +0000
     1.3 @@ -989,11 +989,7 @@
     1.4  		bool IsEqual(ISHDelegate *pOtherDeleg) { return m_Deleg == static_cast<CMyDelegateImpl*>(pOtherDeleg)->m_Deleg; } \
     1.5  	};
     1.6  
     1.7 -// :FIXME:
     1.8 -//  sizeof on references returns the size of the datatype, NOT the pointer size or something
     1.9 -//  -> one should probably flag references in __SourceHook_ParamSizes_* !
    1.10 -//		or simply assume that their size is sizeof(void*)=SH_PTRSIZE... could be doable through a simple template
    1.11 -
    1.12 +// GetPassInfo -> easier access. __SH_GPI generates a SourceHook::PassInfo instance.
    1.13  #define __SH_GPI(tt) { sizeof(tt), ::SourceHook::GetPassInfo< tt >::type, ::SourceHook::GetPassInfo< tt >::flags }
    1.14  
    1.15  
     2.1 --- a/sourcehook/generate/sourcehook.hxx	Fri Oct 12 19:17:52 2007 +0000
     2.2 +++ b/sourcehook/generate/sourcehook.hxx	Fri Oct 12 19:19:17 2007 +0000
     2.3 @@ -989,11 +989,7 @@
     2.4  		bool IsEqual(ISHDelegate *pOtherDeleg) { return m_Deleg == static_cast<CMyDelegateImpl*>(pOtherDeleg)->m_Deleg; } \
     2.5  	};
     2.6  
     2.7 -// :FIXME:
     2.8 -//  sizeof on references returns the size of the datatype, NOT the pointer size or something
     2.9 -//  -> one should probably flag references in __SourceHook_ParamSizes_* !
    2.10 -//		or simply assume that their size is sizeof(void*)=SH_PTRSIZE... could be doable through a simple template
    2.11 -
    2.12 +// GetPassInfo -> easier access. __SH_GPI generates a SourceHook::PassInfo instance.
    2.13  #define __SH_GPI(tt) { sizeof(tt), ::SourceHook::GetPassInfo< tt >::type, ::SourceHook::GetPassInfo< tt >::flags }
    2.14  
    2.15  @[$1,0,$a:
     3.1 --- a/sourcehook/sourcehook.h	Fri Oct 12 19:17:52 2007 +0000
     3.2 +++ b/sourcehook/sourcehook.h	Fri Oct 12 19:19:17 2007 +0000
     3.3 @@ -989,11 +989,7 @@
     3.4  		bool IsEqual(ISHDelegate *pOtherDeleg) { return m_Deleg == static_cast<CMyDelegateImpl*>(pOtherDeleg)->m_Deleg; } \
     3.5  	};
     3.6  
     3.7 -// :FIXME:
     3.8 -//  sizeof on references returns the size of the datatype, NOT the pointer size or something
     3.9 -//  -> one should probably flag references in __SourceHook_ParamSizes_* !
    3.10 -//		or simply assume that their size is sizeof(void*)=SH_PTRSIZE... could be doable through a simple template
    3.11 -
    3.12 +// GetPassInfo -> easier access. __SH_GPI generates a SourceHook::PassInfo instance.
    3.13  #define __SH_GPI(tt) { sizeof(tt), ::SourceHook::GetPassInfo< tt >::type, ::SourceHook::GetPassInfo< tt >::flags }
    3.14  
    3.15