core/ConCmdManager.cpp
author Borja Ferrer <faluco@alliedmods.net>
Fri Jul 04 19:04:33 2008 +0000 (2008-07-04)
changeset 2155 3f1fd7ab3d86
parent 2055 e94e6fcd3f0e
child 2245 d8518466c06c
permissions -rw-r--r--
fixed amb1801, IsFakeClient() wasn't working for TF2 causing false results and crashes
     1 /**
     2  * vim: set ts=4 :
     3  * =============================================================================
     4  * SourceMod
     5  * Copyright (C) 2004-2008 AlliedModders LLC.  All rights reserved.
     6  * =============================================================================
     7  *
     8  * This program is free software; you can redistribute it and/or modify it under
     9  * the terms of the GNU General Public License, version 3.0, as published by the
    10  * Free Software Foundation.
    11  * 
    12  * This program is distributed in the hope that it will be useful, but WITHOUT
    13  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
    14  * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
    15  * details.
    16  *
    17  * You should have received a copy of the GNU General Public License along with
    18  * this program.  If not, see <http://www.gnu.org/licenses/>.
    19  *
    20  * As a special exception, AlliedModders LLC gives you permission to link the
    21  * code of this program (as well as its derivative works) to "Half-Life 2," the
    22  * "Source Engine," the "SourcePawn JIT," and any Game MODs that run on software
    23  * by the Valve Corporation.  You must obey the GNU General Public License in
    24  * all respects for all other code used.  Additionally, AlliedModders LLC grants
    25  * this exception to all derivative works.  AlliedModders LLC defines further
    26  * exceptions, found in LICENSE.txt (as of this writing, version JULY-31-2007),
    27  * or <http://www.sourcemod.net/license.php>.
    28  *
    29  * Version: $Id$
    30  */
    31 
    32 #include "ConCmdManager.h"
    33 #include "sm_srvcmds.h"
    34 #include "AdminCache.h"
    35 #include "sm_stringutil.h"
    36 #include "PlayerManager.h"
    37 #include "Translator.h"
    38 #include "HalfLife2.h"
    39 #include "ChatTriggers.h"
    40 
    41 ConCmdManager g_ConCmds;
    42 
    43 #if defined ORANGEBOX_BUILD
    44 	SH_DECL_HOOK1_void(ConCommand, Dispatch, SH_NOATTRIB, false, const CCommand &);
    45 #else
    46 	SH_DECL_HOOK0_void(ConCommand, Dispatch, SH_NOATTRIB, false);
    47 #endif
    48 
    49 SH_DECL_HOOK1_void(IServerGameClients, SetCommandClient, SH_NOATTRIB, false, int);
    50 
    51 struct PlCmdInfo
    52 {
    53 	ConCmdInfo *pInfo;
    54 	CmdHook *pHook;
    55 	CmdType type;
    56 };
    57 typedef List<PlCmdInfo> CmdList;
    58 
    59 void AddToPlCmdList(CmdList *pList, const PlCmdInfo &info);
    60 
    61 ConCmdManager::ConCmdManager() : m_Strings(1024)
    62 {
    63 	m_pCmds = sm_trie_create();
    64 	m_pCmdGrps = sm_trie_create();
    65 	m_CmdClient = 0;
    66 }
    67 
    68 ConCmdManager::~ConCmdManager()
    69 {
    70 	sm_trie_destroy(m_pCmds);
    71 	sm_trie_destroy(m_pCmdGrps);
    72 }
    73 
    74 void ConCmdManager::OnSourceModAllInitialized()
    75 {
    76 	g_PluginSys.AddPluginsListener(this);
    77 	g_RootMenu.AddRootConsoleCommand("cmds", "List console commands", this);
    78 	SH_ADD_HOOK_MEMFUNC(IServerGameClients, SetCommandClient, serverClients, this, &ConCmdManager::SetCommandClient, false);
    79 }
    80 
    81 void ConCmdManager::OnSourceModShutdown()
    82 {
    83 	/* All commands should already be removed by the time we're done */
    84 	SH_REMOVE_HOOK_MEMFUNC(IServerGameClients, SetCommandClient, serverClients, this, &ConCmdManager::SetCommandClient, false);
    85 	g_RootMenu.RemoveRootConsoleCommand("cmds", this);
    86 }
    87 
    88 void ConCmdManager::OnUnlinkConCommandBase(ConCommandBase *pBase, const char *name, bool is_read_safe)
    89 {
    90 	/* Whoa, first get its information struct */
    91 	ConCmdInfo *pInfo;
    92 
    93 	if (!sm_trie_retrieve(m_pCmds, name, (void **)&pInfo))
    94 	{
    95 		return;
    96 	}
    97 
    98 	RemoveConCmds(pInfo->srvhooks);
    99 	RemoveConCmds(pInfo->conhooks);
   100 
   101 	RemoveConCmd(pInfo, name, is_read_safe, false);
   102 }
   103 
   104 void ConCmdManager::RemoveConCmds(List<CmdHook *> &cmdlist)
   105 {
   106 	List<CmdHook *>::iterator iter = cmdlist.begin();
   107 
   108 	while (iter != cmdlist.end())
   109 	{
   110 		CmdHook *pHook = (*iter);
   111 		IPluginContext *pContext = pHook->pf->GetParentContext();
   112 		IPlugin *pPlugin = g_PluginSys.GetPluginByCtx(pContext->GetContext());
   113 		CmdList *pList = NULL;
   114 		
   115 		//gaben
   116 		if (!pPlugin->GetProperty("CommandList", (void **)&pList, false) || !pList)
   117 		{
   118 			continue;
   119 		}
   120 
   121 		CmdList::iterator p_iter = pList->begin();
   122 		while (p_iter != pList->end())
   123 		{
   124 			PlCmdInfo &cmd = (*p_iter);
   125 			if (cmd.pHook == pHook)
   126 			{
   127 				p_iter = pList->erase(p_iter);
   128 			}
   129 			else
   130 			{
   131 				p_iter++;
   132 			}
   133 		}
   134 
   135 		delete pHook->pAdmin;
   136 		delete pHook;
   137 		
   138 		iter = cmdlist.erase(iter);
   139 	}
   140 }
   141 
   142 void ConCmdManager::RemoveConCmds(List<CmdHook *> &cmdlist, IPluginContext *pContext)
   143 {
   144 	List<CmdHook *>::iterator iter = cmdlist.begin();
   145 	CmdHook *pHook;
   146 
   147 	while (iter != cmdlist.end())
   148 	{
   149 		pHook = (*iter);
   150 		if (pHook->pf->GetParentContext() == pContext)
   151 		{
   152 			delete pHook->pAdmin;
   153 			delete pHook;
   154 			iter = cmdlist.erase(iter);
   155 		}
   156 		else
   157 		{
   158 			iter++;
   159 		}
   160 	}
   161 }
   162 
   163 void ConCmdManager::OnPluginDestroyed(IPlugin *plugin)
   164 {
   165 	CmdList *pList;
   166 	List<ConCmdInfo *> removed;
   167 	if (plugin->GetProperty("CommandList", (void **)&pList, true))
   168 	{
   169 		IPluginContext *pContext = plugin->GetBaseContext();
   170 		CmdList::iterator iter;
   171 		/* First pass!
   172 	 	 * Only bother if there's an actual command list on this plugin... 
   173 	 	 */
   174 		for (iter=pList->begin();
   175 			iter!=pList->end();
   176 			iter++)
   177 		{
   178 			PlCmdInfo &cmd = (*iter);
   179 			ConCmdInfo *pInfo = cmd.pInfo;
   180 
   181 			/* Has this chain already been fully cleaned/removed? */
   182 			if (removed.find(pInfo) != removed.end())
   183 			{
   184 				continue;
   185 			}
   186 
   187 			/* Remove any hooks from us on this command */
   188 			RemoveConCmds(pInfo->conhooks, pContext);
   189 			RemoveConCmds(pInfo->srvhooks, pContext);
   190 
   191 			/* See if there are still hooks */
   192 			if (pInfo->srvhooks.size())
   193 			{
   194 				continue;
   195 			}
   196 			if (pInfo->conhooks.size())
   197 			{
   198 				continue;
   199 			}
   200 
   201 			/* Remove the command, it should be safe now */
   202 			RemoveConCmd(pInfo, pInfo->pCmd->GetName(), true, true);
   203 			removed.push_back(pInfo);
   204 		}
   205 		delete pList;
   206 	}
   207 }
   208 #if defined ORANGEBOX_BUILD
   209 void CommandCallback(const CCommand &command)
   210 {
   211 #else
   212 void CommandCallback()
   213 {
   214 	CCommand command;
   215 #endif
   216 
   217 	g_HL2.PushCommandStack(&command);
   218 
   219 	g_ConCmds.InternalDispatch(command);
   220 
   221 	g_HL2.PopCommandStack();
   222 }
   223 
   224 void ConCmdManager::SetCommandClient(int client)
   225 {
   226 	m_CmdClient = client + 1;
   227 }
   228 
   229 ResultType ConCmdManager::DispatchClientCommand(int client, const char *cmd, int args, ResultType type)
   230 {
   231 	ConCmdInfo *pInfo;
   232 	if (sm_trie_retrieve(m_pCmds, cmd, (void **)&pInfo))
   233 	{
   234 		cell_t result = type;
   235 		cell_t tempres = result;
   236 		List<CmdHook *>::iterator iter;
   237 		CmdHook *pHook;
   238 		for (iter=pInfo->conhooks.begin();
   239 			 iter!=pInfo->conhooks.end();
   240 			 iter++)
   241 		{
   242 			pHook = (*iter);
   243 			if (!pHook->pf->IsRunnable())
   244 			{
   245 				continue;
   246 			}
   247 			if (pHook->pAdmin && !CheckAccess(client, cmd, pHook->pAdmin))
   248 			{
   249 				if (result < Pl_Handled)
   250 				{
   251 					result = Pl_Handled;
   252 				}
   253 				continue;
   254 			}
   255 			pHook->pf->PushCell(client);
   256 			pHook->pf->PushCell(args);
   257 			if (pHook->pf->Execute(&tempres) == SP_ERROR_NONE)
   258 			{
   259 				if (tempres > result)
   260 				{
   261 					result = tempres;
   262 				}
   263 				if (result == Pl_Stop)
   264 				{
   265 					break;
   266 				}
   267 			}
   268 		}
   269 		type = (ResultType)result;
   270 	}
   271 
   272 	return type;
   273 }
   274 
   275 void ConCmdManager::InternalDispatch(const CCommand &command)
   276 {
   277 	int client = m_CmdClient;
   278 
   279 	if (client)
   280 	{
   281 		CPlayer *pPlayer = g_Players.GetPlayerByIndex(client);
   282 		if (!pPlayer || !pPlayer->IsConnected())
   283 		{
   284 			return;
   285 		}
   286 	}
   287 
   288 	/**
   289 	 * Note: Console commands will EITHER go through IServerGameDLL::ClientCommand,
   290 	 * OR this dispatch.  They will NEVER go through both.
   291 	 * -- 
   292 	 * Whether or not it goes through the callback is determined by FCVAR_GAMEDLL
   293 	 */
   294 	const char *cmd = g_HL2.CurrentCommandName();
   295 
   296 	ConCmdInfo *pInfo;
   297 	if (!sm_trie_retrieve(m_pCmds, cmd, (void **)&pInfo))
   298 	{
   299 		return;
   300 	}
   301 
   302 	/* This is a hack to prevent say triggers from firing on messages that were 
   303 	 * blocked because of flooding.  We won't remove this, but the hack will get 
   304 	 * "nicer" when we expose explicit say hooks.
   305 	 */
   306 	if (g_ChatTriggers.WasFloodedMessage())
   307 	{
   308 		return;
   309 	}
   310 
   311 	cell_t result = Pl_Continue;
   312 	int args = command.ArgC() - 1;
   313 
   314 	List<CmdHook *>::iterator iter;
   315 	CmdHook *pHook;
   316 
   317 	/* Execute server-only commands if viable */
   318 	if (client == 0 && pInfo->srvhooks.size())
   319 	{
   320 		cell_t tempres = result;
   321 		for (iter=pInfo->srvhooks.begin();
   322 			 iter!=pInfo->srvhooks.end();
   323 			 iter++)
   324 		{
   325 			pHook = (*iter);
   326 			if (!pHook->pf->IsRunnable())
   327 			{
   328 				continue;
   329 			}
   330 			pHook->pf->PushCell(args);
   331 			if (pHook->pf->Execute(&tempres) == SP_ERROR_NONE)
   332 			{
   333 				if (tempres > result)
   334 				{
   335 					result = tempres;
   336 				}
   337 				if (result == Pl_Stop)
   338 				{
   339 					break;
   340 				}
   341 			}
   342 		}
   343 	
   344 		/* Check if there's an early stop */
   345 		if (result >= Pl_Stop)
   346 		{
   347 			if (!pInfo->sourceMod)
   348 			{
   349 				RETURN_META(MRES_SUPERCEDE);
   350 			}
   351 			return;
   352 		}
   353 	}
   354 
   355 	/* Execute console commands */
   356 	if (pInfo->conhooks.size())
   357 	{
   358 		cell_t tempres = result;
   359 		for (iter=pInfo->conhooks.begin();
   360 			iter!=pInfo->conhooks.end();
   361 			iter++)
   362 		{
   363 			pHook = (*iter);
   364 			if (!pHook->pf->IsRunnable())
   365 			{
   366 				continue;
   367 			}
   368 			if (client 
   369 				&& pHook->pAdmin
   370 				&& !CheckAccess(client, cmd, pHook->pAdmin))
   371 			{
   372 				if (result < Pl_Handled)
   373 				{
   374 					result = Pl_Handled;
   375 				}
   376 				continue;
   377 			}
   378 
   379 			/* On a listen server, sometimes the server host's client index can be set as 0.
   380 			 * So index 1 is passed to the command callback to correct this potential problem.
   381 			 */
   382 			if (!engine->IsDedicatedServer())
   383 			{
   384 				client = g_Players.ListenClient();
   385 			}
   386 
   387 			pHook->pf->PushCell(client);
   388 			pHook->pf->PushCell(args);
   389 
   390 			if (pHook->pf->Execute(&tempres) == SP_ERROR_NONE)
   391 			{
   392 				if (tempres > result)
   393 				{
   394 					result = tempres;
   395 				}
   396 				if (result == Pl_Stop)
   397 				{
   398 					break;
   399 				}
   400 			}
   401 		}
   402 	}
   403 
   404 	if (result >= Pl_Handled)
   405 	{
   406 		if (!pInfo->sourceMod)
   407 		{
   408 			RETURN_META(MRES_SUPERCEDE);
   409 		}
   410 		return;
   411 	}
   412 }
   413 
   414 bool ConCmdManager::CheckCommandAccess(int client, const char *cmd, FlagBits cmdflags)
   415 {
   416 	if (cmdflags == 0 || client == 0)
   417 	{
   418 		return true;
   419 	}
   420 
   421 	/* If running listen server, then client 1 is the server host and should have 'root' access */
   422 	if (client == 1 && !engine->IsDedicatedServer())
   423 	{
   424 		return true;
   425 	}
   426 
   427 	CPlayer *player = g_Players.GetPlayerByIndex(client);
   428 	if (!player 
   429 		|| player->GetEdict() == NULL
   430 		|| player->IsFakeClient())
   431 	{
   432 		return false;
   433 	}
   434 
   435 	AdminId adm = player->GetAdminId();
   436 	if (adm != INVALID_ADMIN_ID)
   437 	{
   438 		FlagBits bits = g_Admins.GetAdminFlags(adm, Access_Effective);
   439 
   440 		/* root knows all, WHOA */
   441 		if ((bits & ADMFLAG_ROOT) == ADMFLAG_ROOT)
   442 		{
   443 			return true;
   444 		}
   445 
   446 		/* Check for overrides
   447 		 * :TODO: is it worth optimizing this?
   448 		 */
   449 		unsigned int groups = g_Admins.GetAdminGroupCount(adm);
   450 		GroupId gid;
   451 		OverrideRule rule;
   452 		bool override = false;
   453 		for (unsigned int i=0; i<groups; i++)
   454 		{
   455 			gid = g_Admins.GetAdminGroup(adm, i, NULL);
   456 			/* First get group-level override */
   457 			override = g_Admins.GetGroupCommandOverride(gid, cmd, Override_CommandGroup, &rule);
   458 			/* Now get the specific command override */
   459 			if (g_Admins.GetGroupCommandOverride(gid, cmd, Override_Command, &rule))
   460 			{
   461 				override = true;
   462 			}
   463 			if (override)
   464 			{
   465 				if (rule == Command_Allow)
   466 				{
   467 					return true;
   468 				}
   469 				else if (rule == Command_Deny)
   470 				{
   471 					return false;
   472 				}
   473 			}
   474 		}
   475 
   476 		/* See if our other flags match */
   477 		if ((bits & cmdflags) == cmdflags)
   478 		{
   479 			return true;
   480 		}
   481 	}
   482 
   483 	return false;
   484 }
   485 
   486 bool ConCmdManager::CheckAccess(int client, const char *cmd, AdminCmdInfo *pAdmin)
   487 {
   488 	if (CheckCommandAccess(client, cmd, pAdmin->eflags))
   489 	{
   490 		return true;
   491 	}
   492 
   493 	edict_t *pEdict = engine->PEntityOfEntIndex(client);
   494 	
   495 	/* If we got here, the command failed... */
   496 	char buffer[128];
   497 	if (!CoreTranslate(buffer, sizeof(buffer), "%T", 2, NULL, "No Access", &client))
   498 	{
   499 		UTIL_Format(buffer, sizeof(buffer), "You do not have access to this command");
   500 	}
   501 
   502 	unsigned int replyto = g_ChatTriggers.GetReplyTo();
   503 	if (replyto == SM_REPLY_CONSOLE)
   504 	{
   505 		char fullbuffer[192];
   506 		UTIL_Format(fullbuffer, sizeof(fullbuffer), "[SM] %s.\n", buffer);
   507 		engine->ClientPrintf(pEdict, fullbuffer);
   508 	}
   509 	else if (replyto == SM_REPLY_CHAT)
   510 	{
   511 		char fullbuffer[192];
   512 		UTIL_Format(fullbuffer, sizeof(fullbuffer), "[SM] %s.", buffer);
   513 		g_HL2.TextMsg(client, HUD_PRINTTALK, fullbuffer);
   514 	}
   515 	
   516 	return false;
   517 }
   518 
   519 bool ConCmdManager::AddConsoleCommand(IPluginFunction *pFunction, 
   520 									   const char *name, 
   521 									   const char *description, 
   522 									   int flags)
   523 {
   524 	ConCmdInfo *pInfo = AddOrFindCommand(name, description, flags);
   525 
   526 	if (!pInfo)
   527 	{
   528 		return false;
   529 	}
   530 
   531 	CmdHook *pHook = new CmdHook();
   532 
   533 	pHook->pf = pFunction;
   534 	if (description && description[0])
   535 	{
   536 		pHook->helptext.assign(description);
   537 	}
   538 	pInfo->conhooks.push_back(pHook);
   539 
   540 	/* Add to the plugin */
   541 	CmdList *pList;
   542 	IPlugin *pPlugin = g_PluginSys.GetPluginByCtx(pFunction->GetParentContext()->GetContext());
   543 	if (!pPlugin->GetProperty("CommandList", (void **)&pList))
   544 	{
   545 		pList = new CmdList();
   546 		pPlugin->SetProperty("CommandList", pList);
   547 	}
   548 	PlCmdInfo info;
   549 	info.pInfo = pInfo;
   550 	info.type = Cmd_Console;
   551 	info.pHook = pHook;
   552 	AddToPlCmdList(pList, info);
   553 
   554 	return true;
   555 }
   556 
   557 bool ConCmdManager::AddAdminCommand(IPluginFunction *pFunction, 
   558 									 const char *name, 
   559 									 const char *group,
   560 									 int adminflags,
   561 									 const char *description, 
   562 									 int flags)
   563 {
   564 	ConCmdInfo *pInfo = AddOrFindCommand(name, description, flags);
   565 
   566 	if (!pInfo)
   567 	{
   568 		return false;
   569 	}
   570 
   571 	CmdHook *pHook = new CmdHook();
   572 	AdminCmdInfo *pAdmin = new AdminCmdInfo();
   573 
   574 	pHook->pf = pFunction;
   575 	if (description && description[0])
   576 	{
   577 		pHook->helptext.assign(description);
   578 	}
   579 	pHook->pAdmin = pAdmin;
   580 
   581 	void *object;
   582 	int grpid;
   583 	if (!sm_trie_retrieve(m_pCmdGrps, group, (void **)&object))
   584 	{
   585 		grpid = m_Strings.AddString(group);
   586 		sm_trie_insert(m_pCmdGrps, group, (void *)grpid);
   587 	}
   588 	else
   589 	{
   590 		grpid = (int)object;
   591 	}
   592 
   593 	pAdmin->cmdGrpId = grpid;
   594 	pAdmin->flags = adminflags;
   595 
   596 	/* First get the command group override, if any */
   597 	bool override = g_Admins.GetCommandOverride(group, 
   598 		Override_CommandGroup,
   599 		&(pAdmin->eflags));
   600 
   601 	/* Next get the command override, if any */
   602 	if (g_Admins.GetCommandOverride(name,
   603 		Override_Command,
   604 		&(pAdmin->eflags)))
   605 	{
   606 		override = true;
   607 	}
   608 
   609 	/* Assign normal flags if there were no overrides */
   610 	if (!override)
   611 	{
   612 		pAdmin->eflags = pAdmin->flags;
   613 	}
   614 
   615 	/* Finally, add the hook */
   616 	pInfo->conhooks.push_back(pHook);
   617 	pInfo->admin = *(pHook->pAdmin);
   618 	pInfo->is_admin_set = true;
   619 
   620 	/* Now add to the plugin */
   621 	CmdList *pList;
   622 	IPlugin *pPlugin = g_PluginSys.GetPluginByCtx(pFunction->GetParentContext()->GetContext());
   623 	if (!pPlugin->GetProperty("CommandList", (void **)&pList))
   624 	{
   625 		pList = new CmdList();
   626 		pPlugin->SetProperty("CommandList", pList);
   627 	}
   628 	PlCmdInfo info;
   629 	info.pInfo = pInfo;
   630 	info.type = Cmd_Admin;
   631 	info.pHook = pHook;
   632 	AddToPlCmdList(pList, info);
   633 
   634 	return true;
   635 }
   636 
   637 bool ConCmdManager::AddServerCommand(IPluginFunction *pFunction, 
   638 									  const char *name, 
   639 									  const char *description, 
   640 									  int flags)
   641 
   642 {
   643 	ConCmdInfo *pInfo = AddOrFindCommand(name, description, flags);
   644 
   645 	if (!pInfo)
   646 	{
   647 		return false;
   648 	}
   649 
   650 	CmdHook *pHook = new CmdHook();
   651 
   652 	pHook->pf = pFunction;
   653 	if (description && description[0])
   654 	{
   655 		pHook->helptext.assign(description);
   656 	}
   657 
   658 	pInfo->srvhooks.push_back(pHook);
   659 
   660 	/* Add to the plugin */
   661 	CmdList *pList;
   662 	IPlugin *pPlugin = g_PluginSys.GetPluginByCtx(pFunction->GetParentContext()->GetContext());
   663 	if (!pPlugin->GetProperty("CommandList", (void **)&pList))
   664 	{
   665 		pList = new CmdList();
   666 		pPlugin->SetProperty("CommandList", pList);
   667 	}
   668 	PlCmdInfo info;
   669 	info.pInfo = pInfo;
   670 	info.type = Cmd_Server;
   671 	info.pHook = pHook;
   672 	AddToPlCmdList(pList, info);
   673 
   674 	return true;
   675 }
   676 
   677 void AddToPlCmdList(CmdList *pList, const PlCmdInfo &info)
   678 {
   679 	CmdList::iterator iter = pList->begin();
   680 	bool inserted = false;
   681 	const char *orig = NULL;
   682 
   683 	orig = info.pInfo->pCmd->GetName();
   684 
   685 	/* Insert this into the help list, SORTED alphabetically. */
   686 	while (iter != pList->end())
   687 	{
   688 		PlCmdInfo &obj = (*iter);
   689 		const char *cmd = obj.pInfo->pCmd->GetName();
   690 		if (strcmp(orig, cmd) < 0)
   691 		{
   692 			pList->insert(iter, info);
   693 			inserted = true;
   694 			break;
   695 		}
   696 		iter++;
   697 	}
   698 
   699 	if (!inserted)
   700 	{
   701 		pList->push_back(info);
   702 	}
   703 }
   704 
   705 void ConCmdManager::AddToCmdList(ConCmdInfo *info)
   706 {
   707 	List<ConCmdInfo *>::iterator iter = m_CmdList.begin();
   708 	ConCmdInfo *pInfo;
   709 	bool inserted = false;
   710 	const char *orig = NULL;
   711 
   712 	orig = info->pCmd->GetName();
   713 
   714 	/* Insert this into the help list, SORTED alphabetically. */
   715 	while (iter != m_CmdList.end())
   716 	{
   717 		const char *cmd = NULL;
   718 		pInfo = (*iter);
   719 		cmd = pInfo->pCmd->GetName();
   720 		if (strcmp(orig, cmd) < 0)
   721 		{
   722 			m_CmdList.insert(iter, info);
   723 			inserted = true;
   724 			break;
   725 		}
   726 		iter++;
   727 	}
   728 
   729 	if (!inserted)
   730 	{
   731 		m_CmdList.push_back(info);
   732 	}
   733 }
   734 
   735 void ConCmdManager::UpdateAdminCmdFlags(const char *cmd, OverrideType type, FlagBits bits, bool remove)
   736 {
   737 	ConCmdInfo *pInfo;
   738 
   739 	if (type == Override_Command)
   740 	{
   741 		if (!sm_trie_retrieve(m_pCmds, cmd, (void **)&pInfo))
   742 		{
   743 			return;
   744 		}
   745 
   746 		List<CmdHook *>::iterator iter;
   747 		CmdHook *pHook;
   748 
   749 		for (iter=pInfo->conhooks.begin(); iter!=pInfo->conhooks.end(); iter++)
   750 		{
   751 			pHook = (*iter);
   752 			if (pHook->pAdmin)
   753 			{
   754 				if (!remove)
   755 				{
   756 					pHook->pAdmin->eflags = bits;
   757 				} else {
   758 					pHook->pAdmin->eflags = pHook->pAdmin->flags;
   759 				}
   760 				pInfo->admin = *(pHook->pAdmin);
   761 			}
   762 		}
   763 		pInfo->is_admin_set = true;
   764 	}
   765 	else if (type == Override_CommandGroup)
   766 	{
   767 		void *object;
   768 		if (!sm_trie_retrieve(m_pCmdGrps, cmd, &object))
   769 		{
   770 			return;
   771 		}
   772 		int grpid = (int)object;
   773 
   774 		/* This is bad :( loop through all commands */
   775 		List<ConCmdInfo *>::iterator iter;
   776 		CmdHook *pHook;
   777 		for (iter=m_CmdList.begin(); iter!=m_CmdList.end(); iter++)
   778 		{
   779 			pInfo = (*iter);
   780 			for (List<CmdHook *>::iterator citer=pInfo->conhooks.begin();
   781 				 citer!=pInfo->conhooks.end();
   782 				 citer++)
   783 			{
   784 				pHook = (*citer);
   785 				if (pHook->pAdmin && pHook->pAdmin->cmdGrpId == grpid)
   786 				{
   787 					if (remove)
   788 					{
   789 						pHook->pAdmin->eflags = bits;
   790 					} else {
   791 						pHook->pAdmin->eflags = pHook->pAdmin->flags;
   792 					}
   793 					pInfo->admin = *(pHook->pAdmin);
   794 				}
   795 			}
   796 		}
   797 		pInfo->is_admin_set = true;
   798 	}
   799 }
   800 
   801 void ConCmdManager::RemoveConCmd(ConCmdInfo *info, const char *name, bool is_read_safe, bool untrack)
   802 {
   803 	/* Remove from the trie */
   804 	sm_trie_delete(m_pCmds, name);
   805 
   806 	/* Remove console-specific information
   807 	 * This should always be true as of right now
   808 	 */
   809 	if (info->pCmd)
   810 	{
   811 		if (info->sourceMod)
   812 		{
   813 			/* Unlink from SourceMM */
   814 			g_SMAPI->UnregisterConCommandBase(g_PLAPI, info->pCmd);
   815 			/* Delete the command's memory */
   816 			char *new_help = const_cast<char *>(info->pCmd->GetHelpText());
   817 			char *new_name = const_cast<char *>(info->pCmd->GetName());
   818 			delete [] new_help;
   819 			delete [] new_name;
   820 			delete info->pCmd;
   821 		}
   822 		else
   823 		{
   824 			if (is_read_safe)
   825 			{
   826 				/* Remove the external hook */
   827 				SH_REMOVE_HOOK_STATICFUNC(ConCommand, Dispatch, info->pCmd, CommandCallback, false);
   828 			}
   829 			if (untrack)
   830 			{
   831 				UntrackConCommandBase(info->pCmd, this);
   832 			}
   833 		}
   834 	}
   835 	
   836 	/* Remove from list */
   837 	m_CmdList.remove(info);
   838 
   839 	delete info;
   840 }
   841 
   842 bool ConCmdManager::LookForSourceModCommand(const char *cmd)
   843 {
   844 	ConCmdInfo *pInfo;
   845 
   846 	if (!sm_trie_retrieve(m_pCmds, cmd, (void **)&pInfo))
   847 	{
   848 		return false;
   849 	}
   850 
   851 	return pInfo->sourceMod && (pInfo->conhooks.size() > 0);
   852 }
   853 
   854 bool ConCmdManager::LookForCommandAdminFlags(const char *cmd, FlagBits *pFlags)
   855 {
   856 	ConCmdInfo *pInfo;
   857 
   858 	if (!sm_trie_retrieve(m_pCmds, cmd, (void **)&pInfo))
   859 	{
   860 		return false;
   861 	}
   862 
   863 	*pFlags = pInfo->admin.eflags;
   864 
   865 	return pInfo->is_admin_set;
   866 }
   867 
   868 ConCmdInfo *ConCmdManager::AddOrFindCommand(const char *name, const char *description, int flags)
   869 {
   870 	ConCmdInfo *pInfo;
   871 	if (!sm_trie_retrieve(m_pCmds, name, (void **)&pInfo))
   872 	{
   873 		pInfo = new ConCmdInfo();
   874 		/* Find the commandopan */
   875 		ConCommandBase *pBase = icvar->GetCommands();
   876 		ConCommand *pCmd = NULL;
   877 		while (pBase)
   878 		{
   879 			if (strcmp(pBase->GetName(), name) == 0)
   880 			{
   881 				/* Don't want to return convar with same name */
   882 				if (!pBase->IsCommand())
   883 				{
   884 					return NULL;
   885 				}
   886 
   887 				pCmd = (ConCommand *)pBase;
   888 				break;
   889 			}
   890 			pBase = const_cast<ConCommandBase *>(pBase->GetNext());
   891 		}
   892 
   893 		if (!pCmd)
   894 		{
   895 			/* Note that we have to duplicate because the source might not be 
   896 			 * a static string, and these expect static memory.
   897 			 */
   898 			if (!description)
   899 			{
   900 				description = "";
   901 			}
   902 			char *new_name = sm_strdup(name);
   903 			char *new_help = sm_strdup(description);
   904 			pCmd = new ConCommand(new_name, CommandCallback, new_help, flags);
   905 			pInfo->sourceMod = true;
   906 		}
   907 		else
   908 		{
   909 			TrackConCommandBase(pCmd, this);
   910 			SH_ADD_HOOK_STATICFUNC(ConCommand, Dispatch, pCmd, CommandCallback, false);
   911 		}
   912 
   913 		pInfo->pCmd = pCmd;
   914 		pInfo->is_admin_set = false;
   915 
   916 		sm_trie_insert(m_pCmds, name, pInfo);
   917 		AddToCmdList(pInfo);
   918 	}
   919 
   920 	return pInfo;
   921 }
   922 
   923 void ConCmdManager::OnRootConsoleCommand(const char *cmdname, const CCommand &command)
   924 {
   925 	if (command.ArgC() >= 3)
   926 	{
   927 		const char *text = command.Arg(2);
   928 
   929 		CPlugin *pPlugin = g_PluginSys.FindPluginByConsoleArg(text);
   930 
   931 		if (!pPlugin)
   932 		{
   933 			g_RootMenu.ConsolePrint("[SM] Plugin \"%s\" was not found.", text);
   934 			return;
   935 		}
   936 
   937 		const sm_plugininfo_t *plinfo = pPlugin->GetPublicInfo();
   938 		const char *plname = IS_STR_FILLED(plinfo->name) ? plinfo->name : pPlugin->GetFilename();
   939 
   940 		CmdList *pList;
   941 		if (!pPlugin->GetProperty("CommandList", (void **)&pList))
   942 		{
   943 			g_RootMenu.ConsolePrint("[SM] No commands found for: %s", plname);
   944 			return;
   945 		}
   946 		if (!pList->size())
   947 		{
   948 			g_RootMenu.ConsolePrint("[SM] No commands found for: %s", plname);
   949 			return;
   950 		}
   951 
   952 		CmdList::iterator iter;
   953 		const char *type = NULL;
   954 		const char *name;
   955 		const char *help;
   956 		g_RootMenu.ConsolePrint("[SM] Listing %d commands for: %s", pList->size(), plname);
   957 		g_RootMenu.ConsolePrint("  %-17.16s %-8.7s %s", "[Name]", "[Type]", "[Help]");
   958 		for (iter=pList->begin();
   959 			 iter!=pList->end();
   960 			 iter++)
   961 		{
   962 			PlCmdInfo &cmd = (*iter);
   963 			if (cmd.type == Cmd_Server)
   964 			{
   965 				type = "server";
   966 			}
   967 			else if (cmd.type == Cmd_Console)
   968 			{
   969 				type = "console";
   970 			}
   971 			else if (cmd.type == Cmd_Admin)
   972 			{
   973 				type = "admin";
   974 			}
   975 			name = cmd.pInfo->pCmd->GetName();
   976 			if (cmd.pHook->helptext.size())
   977 			{
   978 				help = cmd.pHook->helptext.c_str();
   979 			}
   980 			else
   981 			{
   982 				help = cmd.pInfo->pCmd->GetHelpText();
   983 			}
   984 			g_RootMenu.ConsolePrint("  %-17.16s %-12.11s %s", name, type, help);		
   985 		}
   986 
   987 		return;
   988 	}
   989 
   990 	g_RootMenu.ConsolePrint("[SM] Usage: sm cmds <plugin #>");
   991 }