Re-implement array assignment.
1 /* vim: set ts=4 sw=4 tw=99 et:
3 * Copyright (C) 2012 David Anderson
5 * This file is part of SourcePawn.
7 * SourcePawn is free software: you can redistribute it and/or modify it under
8 * the terms of the GNU General Public License as published by the Free
9 * Software Foundation, either version 3 of the License, or (at your option)
12 * SourcePawn is distributed in the hope that it will be useful, but WITHOUT ANY
13 * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
14 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
16 * You should have received a copy of the GNU General Public License along with
17 * SourcePawn. If not, see http://www.gnu.org/licenses/.
21 #include "../Strings.h"
22 #include "../NativeTable.h"
23 #include "../TypeManager.h"
24 #include "../Modules.h"
26 #include "SemanticAnalysis.h"
27 #include "../Heap-inl.h"
33 typedef BytecodeEmitter::Label Label;
38 AutoEnterScope(Scope **prevp, Scope *scope)
47 assert(prev_ == scope->enclosing());
60 SemanticAnalysis::SemanticAnalysis(Zone *zone, CompileContext &cc, TranslationUnit *unit)
72 SemanticAnalysis::SemanticAnalysis(SemanticAnalysis *parent, Handle<FunctionType> fun)
73 : zone_(parent->zone_),
78 scope_(parent->scope_),
80 module_(parent->module_),
89 SemanticAnalysis::analyze()
91 scope_ = unit_->globalScope();
93 module_ = Module::New(zone_);
95 for (size_t i = 0; i < unit_->tree()->statements()->length(); i++) {
96 Statement *stmt = unit_->tree()->statements()->at(i);
100 Local<Struct> globals(zone_, unit_->globalScope()->build(zone_));
103 module_->setGlobals(globals);
105 Local<Code> code(zone_, __ finish());
108 code->setModule(module_);
109 module_->setCode(code);
112 // Disassemble(code, stdout);
115 unit_->module_ = module_;
119 SemanticAnalysis::visitFunctionStatement(FunctionStatement *stmt)
121 FunctionSymbol *sym = stmt->sym();
122 Local<FunctionType> type(zone_, sym->type());
124 assert(scope_->kind() == Scope::GLOBAL);
126 if (stmt->token() == TOK_NATIVE) {
127 // Define the native now.
129 if (!zone_->nativeTable()->add(stmt->name(), &index))
132 Local<Native> native(zone_, Native::New(zone_, type, index));
141 // If the function is a forward or native, we don't have to do anything.
142 if (stmt->token() == TOK_NATIVE || stmt->token() == TOK_FORWARD)
145 SemanticAnalysis child(this, type);
146 Local<Function> funobj(zone_, child.compile(stmt));
152 if (stmt->token() == TOK_PUBLIC)
159 SemanticAnalysis::compile(FunctionStatement *stmt)
161 __ setFirstLine(stmt->pos().line);
163 AutoEnterScope argScope(&scope_, stmt->argScope());
165 for (size_t i = 0; i < stmt->signature().parameters()->length(); i++) {
166 Parameter *param = stmt->signature().parameters()->at(i);
167 param->sym()->allocate(VariableSymbol::Arg, i);
170 AutoEnterScope varScope(&scope_, stmt->varScope());
171 ControlStatus status = visitForControl(stmt->body());
173 if (!fun_->returnType()->isVoid()) {
174 // If the function is not void, report if not all paths return a value.
175 // All other incorrect return cases have been caught already.
176 if (status.returns() == Returns_Sometimes) {
177 cc_.reportError(stmt->pos(), Message_NotAllPathsReturnValue);
181 if (status.returns() == Returns_Never) {
182 cc_.reportError(stmt->pos(), Message_MissingReturnValue);
187 Local<Code> code(zone_, __ finish());
190 code->setModule(module_);
192 Local<Function> fun(zone_, Function::New(zone_, code, fun_, stmt->name(), stmt->pos()));
197 // Disassemble(code, stdout);
204 SemanticAnalysis::visitBlockStatement(BlockStatement *node)
206 AutoEnterScope scope(&scope_, node->scope());
208 for (size_t i = 0; i < node->statements()->length(); i++) {
209 Statement *stmt = node->statements()->at(i);
210 __ note_position(stmt->pos());
212 assert(__ stackDepth() == 0);
217 SemanticAnalysis::visitEnumStatement(EnumStatement *node)
222 SemanticAnalysis::visitExpressionStatement(ExpressionStatement *node)
224 // While building HIR, we enter new pool and root scopes, since HIR
225 // creation is purely temporary.
226 PoolScope poolScope(zone_->pool());
227 RootScope rootScope(zone_);
229 HIR *hir = eval(node->expression());
234 if (!hir->type()->isVoid())
239 SemanticAnalysis::ControlScope::merge(const ControlStatus &left, const ControlStatus &right)
241 // If both sides terminate in a return, we consider this a return as well.
242 if (left.returns() == Returns_Always && right.returns() == Returns_Always) {
243 terminate(Returns_Always);
247 ReturnStatus status = (left.returns() == Returns_Never && right.returns() == Returns_Never)
251 if (left.terminates() && right.terminates())
257 SemanticAnalysis::ControlStatus
258 SemanticAnalysis::visitForControl(Statement *statement)
260 ControlScope scope(&control_);
261 statement->accept(this);
262 return scope.status();
266 SemanticAnalysis::visitIfStatement(IfStatement *node)
270 ControlStatus trueBranch;
271 ControlStatus falseBranch(false, Returns_Never);
273 if (!node->ifFalse()) {
276 visitForTest(node->condition(), &success, &join, &success);
278 trueBranch = visitForControl(node->ifTrue());
282 visitForTest(node->condition(), &success, &next, &success);
284 trueBranch = visitForControl(node->ifTrue());
287 falseBranch = visitForControl(node->ifFalse());
292 control_->merge(trueBranch, falseBranch);
296 SemanticAnalysis::requireLifoStack()
301 loop_->setUsesLifoStack();
304 SemanticAnalysis::ControlStatus
305 SemanticAnalysis::visitLoopBody(Statement *stmt)
307 // We always mark off a loop body, so on each edge, we can balance the
308 // LIFO stack. Right now, we don't have the ability to budget the LIFO
309 // stack ahead of time. If we turn out to never need the LIFO stack, we
310 // mark it as unnecessary. (The interpreter can't really make use of this,
313 // Note that balancing the LIFO stack isn't even necessary, so this
314 // feature may be removed. All this mechanism does is mitigate the
315 // possibility that a long-running loop will overflow the LIFO region
316 // and therefore start requiring nursery allocations.
317 int pos = __ enterloop();
318 ControlStatus status = visitForControl(stmt);
321 if (loop_->usesLifoStack())
322 __ setLoopUsesLifoStack(pos);
328 SemanticAnalysis::visitForStatement(ForStatement *node)
330 AutoEnterScope scope(&scope_, node->scope());
331 PoolScope poolScope(zone_->pool());
332 RootScope rootScope(zone_);
335 LoopScope loop(scope_, &join, &update, &loop_);
337 if (node->initialization())
338 node->initialization()->accept(this);
341 if (node->condition())
345 ControlStatus status = visitLoopBody(node->body());
349 node->update()->accept(this);
351 if (node->condition()) {
353 visitForTest(node->condition(), &header, &join, &join);
360 // If there was a condition, we treat this like a while loop. Otherwise,
361 // the join point is only reachable if the loop contains a break. The
362 // termination status doesn't tell us anything yet.
363 if (node->condition() || loop.breaks())
364 control_->merge(status, ControlStatus(false, Returns_Never));
366 control_->terminate(status.returns());
368 assert(__ stackDepth() == 0);
372 SemanticAnalysis::visitWhileStatement(WhileStatement *node)
374 PoolScope poolScope(zone_->pool());
375 RootScope rootScope(zone_);
381 ControlStatus status;
383 LoopScope loop(scope_, &join, &header, &loop_);
384 if (node->token() == TOK_WHILE) {
386 visitForTest(node->condition(), &body, &join, &body);
387 status = visitLoopBody(node->body());
390 status = visitLoopBody(node->body());
391 visitForTest(node->condition(), &header, &join, &join);
396 // Detect loops that will always have a fork in the contro-flow graph.
397 // This will be a |while| loop, or a |do-while| loop whose body does
398 // not terminate. For now, we treat these as an |if| regardless of the
399 // direction the branch can take. That means the control-flow is always
401 if (node->token() == TOK_WHILE || status.terminates() || loop.breaks()) {
402 control_->merge(status, ControlStatus(false, Returns_Never));
404 // At this point, we've got a do-while loop with a |return| or
405 // |continue|, meaning that the rest of the block is unreachable.
406 control_->terminate(status.returns());
409 assert(__ stackDepth() == 0);
412 static inline Heap::Tenure
413 InferTenure(Symbol *sym)
415 if (sym->scope()->kind() == Scope::GLOBAL)
416 return Heap::Tenure_Old;
418 // SP2's array semantics allow any array kind to escape, so we must use
419 // the normal heap. (Hopefully escape analysis can ease this pain later).
420 if (sym->type()->isArray())
421 return Heap::Tenure_Default;
423 return Heap::Tenure_Default;
427 SemanticAnalysis::visitVariableDeclaration(VariableDeclaration *node)
429 PoolScope poolScope(zone_->pool());
430 RootScope rootScope(zone_);
432 Local<Type> type(zone_, node->sym()->type());
434 if (node->initialization()) {
437 if ((hir = eval(node->initialization())) == NULL)
439 if ((hir = coerce(hir, type, Coerce_Decl)) == NULL)
444 if (type->isInt32() || type->isEnum() ||
445 type->isChar() || type->isBool())
448 } else if (type->isFloat()) {
450 } else if (type->isArray()) {
451 Local<ArrayType> atype(zone_, ArrayType::cast(type));
452 Local<ArrayMap> map(zone_, ArrayMap::Attach(zone_, atype));
456 if (atype->isFixedLength()) {
457 __ newarray(OP_NEWFIXED, map, InferTenure(node->sym()));
458 } else if (node->dims()->at(0)) {
459 // This may not be true if we allow typedefing, so :TODO:
460 // figure out proper semantics.
461 assert(node->dims()->length() == atype->levels());
463 Local<Type> i32(zone_, zone_->types()->getPrimitive(PrimitiveType_Int32));
464 for (size_t i = 0; i < node->dims()->length(); i++) {
465 Expression *expr = node->dims()->at(i);
467 HIR *hir = eval(expr);
468 if (!hir || ((hir = coerce(hir, i32, Coerce_Arg)) == NULL))
475 __ newarray(OP_NEWSIZED, map, InferTenure(node->sym()));
477 __ newarray(OP_NEWEMPTY, map, InferTenure(node->sym()));
484 if (node->sym()->scope()->kind() != Scope::GLOBAL) {
485 if (!__ allocate(node->sym()))
494 SemanticAnalysis::visitReturnStatement(ReturnStatement *node)
496 control_->returns(Returns_Always);
498 if (!node->expression()) {
499 if (!fun_->returnType()->isVoid()) {
500 cc_.reportError(node->pos(), Message_MissingReturnValue);
508 if (fun_->returnType()->isVoid()) {
509 cc_.reportError(node->pos(), Message_UsedVoidReturn);
513 PoolScope poolScope(zone_->pool());
514 RootScope rootScope(zone_);
516 HIR *hir = eval(node->expression());
520 Local<Type> returnType(zone_, fun_->returnType());
521 if ((hir = coerce(hir, returnType, Coerce_Return)) == NULL)
526 if (hir->type()->isVoid())
533 SemanticAnalysis::visitBinaryExpression(BinaryExpression *node)
535 HIR *left = eval(node->left());
536 HIR *right = eval(node->right());
540 hir_ = binary(node, node->token(), left, right);
544 SemanticAnalysis::checkArgumentCount(Handle<FunctionType> type, unsigned actual)
546 if (type->parameters()->length() == actual)
549 if (actual > type->parameters()->length()) {
550 if (!type->isNative() || !type->isNativeVariadic())
555 if (!type->defaults())
558 // Missing arguments. See if there's a default argument for each missing
560 for (unsigned i = actual; i < type->parameters()->length(); i++) {
561 if (!type->defaults()->at(i))
569 SemanticAnalysis::visitNameProxy(NameProxy *proxy)
571 Symbol *sym = proxy->sym();
573 switch (sym->kind()) {
574 case Symbol::kConstant:
576 ConstantSymbol *val = sym->toConstant();
577 hir_ = new (pool_) HInteger(proxy, sym->type(), val->value().toInt());
581 // This is kind of screwy. Symbol::kFunction is like a constant we can't
582 // evaluate yet. Maybe we should extract the GLOBAL case and say that
583 // kFunction is only used for global functions (and use const vars for
585 case Symbol::kFunction:
586 case Symbol::kVariable:
588 Scope *in = sym->scope();
589 switch (in->kind()) {
591 hir_ = new (pool_) HGlobal(proxy, sym);
594 case Scope::FUNCTION:
596 VariableSymbol *var = sym->toVariable();
597 assert(var->storage() == VariableSymbol::Arg);
598 hir_ = new (pool_) HLocal(proxy, var);
604 VariableSymbol *var = sym->toVariable();
605 assert(in->kind() == Scope::BLOCK);
606 assert(var->storage() == VariableSymbol::Local);
607 hir_ = new (pool_) HLocal(proxy, var);
621 SemanticAnalysis::visitIntegerLiteral(IntegerLiteral *lit)
623 Local<Type> type(zone_, zone_->types()->getPrimitive(PrimitiveType_Int32));
624 hir_ = new (pool_) HInteger(lit, type, lit->value());
628 SemanticAnalysis::visitFloatLiteral(FloatLiteral *node)
630 Local<Type> type(zone_, zone_->types()->getPrimitive(PrimitiveType_Float));
631 hir_ = new (pool_) HFloat(node, type, (float)node->value());
635 SemanticAnalysis::visitStringLiteral(StringLiteral *node)
637 Type *type = zone_->types()->getString();
638 hir_ = new (pool_) HString(node, type, node->string());
642 SemanticAnalysis::visitCallExpression(CallExpression *node)
644 HIR *callee = eval(node->callee());
648 if (!callee->type()->isFunction()) {
649 cc_.reportError(node->pos(), Message_CalleeNotFunction);
653 Local<FunctionType> fun(zone_, FunctionType::cast(callee->type()));
655 if (!checkArgumentCount(fun, node->arguments()->length())) {
656 cc_.reportError(node->pos(), Message_ArgumentCountMismatch);
660 if (fun->isForward()) {
661 cc_.reportError(node->pos(), Message_ForwardNotImplemented, fun->name()->chars());
665 HIRList *args = new (pool_) HIRList;
666 for (unsigned i = 0; i < node->arguments()->length(); i++) {
667 Expression *expression = node->arguments()->at(i);
668 HIR *arg = eval(expression);
672 Handle<Type> given = arg->type();
674 bool mustComputeReference;
675 if (i >= fun->parameters()->length()) {
676 // Special handling for natives. Arguments past the formal must
677 // always have references computed. However, arrays are already
678 // references for natives.
679 assert(fun->isNative() && fun->isNativeVariadic());
680 mustComputeReference = !given->isReference() &&
683 Local<Type> actual(zone_, fun->parameterAt(i));
685 if (expression->isIndexExpression()) {
686 // Temporarily disabled.
687 assert(!actual->isArray());
688 if (actual->isReference()) {
689 cc_.reportError(expression->pos(), Message_CannotComputeIndexRef);
694 if (actual->isReference()) {
695 // If the actual is a reference, the coercion rules are much
696 // stricter; the contained types must be identical.
697 // :TODO: make this not an assert
698 assert(ReferenceType::cast(actual)->contained() == arg->type());
700 // When we start overloading, coercion will have to happen later.
701 arg = coerce(arg, actual, Coerce_Arg);
706 mustComputeReference = actual->isReference() && !given->isReference();
709 if (mustComputeReference) {
710 // Refs always use the LIFO stack if they can.
711 arg = new (pool_) HToRef(arg->node(), arg->type(), arg);
715 if (!args->append(arg))
719 hir_ = new (pool_) HCall(node, fun->returnType(), callee, args);
723 SemanticAnalysis::visitAssignment(Assignment *node)
725 HLValue *lval = lvalue(node->lvalue());
729 HIR *hir = eval(node->expression());
730 if ((hir = coerce(hir, lval->type(), Coerce_Assign)) == NULL)
733 hir_ = new (pool_) HStore(node, node->token(), lval, hir);
737 SemanticAnalysis::visitBreakStatement(BreakStatement *node)
740 cc_.reportError(node->pos(), Message_BreakOutsideLoop);
745 __ j(OP_BREAK, loop_->break_());
749 SemanticAnalysis::visitContinueStatement(ContinueStatement *node)
752 cc_.reportError(node->pos(), Message_ContinueOutsideLoop);
756 __ j(OP_CONTINUE, loop_->continue_());
760 SemanticAnalysis::visitIndexExpression(IndexExpression *node)
762 HIR *left = eval(node->left());
766 HIR *right = eval(node->right());
770 // Hrm... yes, for now, let's coerce here.
771 Local<Type> i32(zone_, zone_->types()->getPrimitive(PrimitiveType_Int32));
772 if ((right = coerce(right, i32, Coerce_Arg)) == NULL)
775 // Do not coerce here, there's no reason to yet.
776 if (!left->type()->isArray()) {
777 cc_.reportError(node->left()->pos(), Message_IndexBaseMustBeArray);
781 hir_ = new (pool_) HIndex(node,
782 ArrayType::cast(left->type())->contained(),
788 SemanticAnalysis::visitIncDecExpression(IncDecExpression *node)
790 HLValue *lval = lvalue(node->expression());
794 if (!lval->type()->isInt32() && !lval->type()->isFloat()) {
800 if (lval->type()->isInt32())
801 rval = new (pool_) HInteger(node, lval->type(), 1);
803 rval = new (pool_) HFloat(node, lval->type(), 1.0);
806 hir_ = new (pool_) HPostIncDec(node, node->token(), lval, rval);
808 hir_ = new (pool_) HStore(node, node->token(), lval, rval);
812 SemanticAnalysis::coercionType(TokenKind token, HIR *left, HIR *right)
814 Handle<Type> l = left->type();
815 Handle<Type> r = right->type();
817 if (token >= TOK_PLUS && token <= TOK_SLASH) {
818 // We allow: [float|int32] + [float|int32]
819 if (l->isFloat() && r->isInt32())
821 if (l->isInt32() && r->isFloat())
823 if (l->isInt32() && r->isInt32())
834 SemanticAnalysis::typeCheckArray(const SourcePosition &pos,
836 Handle<Type> argActual,
839 Local<Type> argGiven(zone_, from->type());
841 // Special case: if we receive a string literal, and this is a char array,
842 // we allow a coercion.
843 if (from->isString() &&
844 argGiven->isString() &&
845 argActual->isArray() &&
846 ArrayType::cast(argActual)->isCharArray())
848 HString *hir = from->toString();
849 Local<ArrayType> actual(zone_, ArrayType::cast(argActual));
851 if (actual->isFixedLength()) {
852 if (hir->string()->length() + 1 > actual->fixedLength()) {
853 cc_.reportError(pos, Message_ArrayAssignmentTooBig);
858 // Transform the string literal into an array literal. We give it the
859 // type of the left-hand side. The constness of the destination type
860 // will determine whether HArray duplicates it or not.
861 Local<ArrayMap> map(zone_, ArrayMap::Attach(zone_, actual));
865 Local<Array> array(zone_);
866 array = Array::NewString(zone_,
868 hir->string()->chars(),
869 hir->string()->length(),
874 // Since we're creating a canonical copy of the char array, we have to
875 // be careful that it doesn't get mutated. There are two cases where
876 // we know it can't be mutated, and therefore don't need to specify
877 // that it be cloned after pushing it onto the stack.
879 // (1) The array type is const.
880 // (2) The array type is fixed-length, and the coercion is for
881 // assignment, meaning it will be immediately copied.
883 // We treat declaration separately from assignment, since for
884 // declaration we can just immediately use the cloned version.
885 bool shouldDuplicate = true;
886 if (actual->isConst() ||
887 (actual->isFixedLength() && kind == Coerce_Assign))
889 shouldDuplicate = false;
892 return new (pool_) HArray(hir->node(), actual, array, shouldDuplicate);
895 if (!argGiven->isArray()) {
896 cc_.reportError(pos, Message_ExpectedArray);
900 Local<ArrayType> actual(zone_, ArrayType::cast(argActual));
901 Local<ArrayType> given(zone_, ArrayType::cast(argGiven));
903 if (actual->levels() != given->levels()) {
904 cc_.reportError(pos, Message_ArrayDimensionsMismatch);
910 if (actual->isFixedLength()) {
911 if (!given->isFixedLength()) {
912 cc_.reportError(pos, Message_ArrayDimensionSizeMismatch, level);
916 if (actual->isCharArray()) {
917 // String assignment can have a truncated |given|.
918 if (given->fixedLength() > actual->fixedLength()) {
919 cc_.reportError(pos, Message_ArrayAssignmentTooBig);
923 if (given->fixedLength() != actual->fixedLength()) {
924 cc_.reportError(pos, Message_ArrayDimensionSizeMismatch, level);
928 } else if (given->isFixedLength()) {
929 // We do not allow assignments in the form:
932 // Otherwise, the following code could break the size guarantees
933 // of the right-hand side:
943 // Now |x[0]| contains a 3-length array.
945 cc_.reportError(pos, Message_ArrayDimensionSizeMismatch, level);
950 if (!given->contained()->isArray() || !actual->contained()->isArray())
953 given = ArrayType::cast(given->contained());
954 actual = ArrayType::cast(actual->contained());
957 // These arrays must contain the same innermost type.
958 if (given->contained() != actual->contained()) {
959 cc_.reportError(pos, Message_TypeMismatch,
960 GetTypeName(actual->contained()),
961 GetTypeName(given->contained()));
969 SemanticAnalysis::typeFailure(const SourcePosition &pos, Handle<Type> from, Handle<Type> to)
971 cc_.reportError(pos, Message_InvalidCoercion,
978 SemanticAnalysis::coerce(HIR *hir, Handle<Type> to, CoercionKind kind)
980 Local<Type> from(zone_, hir->type());
982 if (from->isInt32() && to->isFloat())
983 return new (pool_) HConvert(hir->node(), to, OP_CVT_I2F, hir);
984 if (from->isInt32() && to->isBool())
985 return new (pool_) HConvert(hir->node(), to, OP_CVT_I2B, hir);
987 if (to->isEnum() && *from != to)
988 return typeFailure(hir->node()->pos(), from, to);
991 return typeCheckArray(SourcePosition(), hir, to, kind);
997 SemanticAnalysis::set(VariableSymbol *sym)
999 if (sym->scope()->kind() == Scope::GLOBAL) {
1002 assert(sym->storage() == VariableSymbol::Local);
1008 SemanticAnalysis::binary(AstNode *node, TokenKind token, HIR *left, HIR *right)
1010 Local<Type> coercion(zone_, coercionType(token, left, right));
1013 if ((left = coerce(left, coercion, Coerce_Arg)) == NULL)
1015 if ((right = coerce(right, coercion, Coerce_Arg)) == NULL)
1030 return new (pool_) HBinary(node, left->type(), token, left, right);
1041 Local<Type> result(zone_, zone_->types()->getPrimitive(PrimitiveType_Bool));
1042 return new (pool_) HBinary(node, result, token, left, right);
1051 static inline TokenKind
1052 ToCompare(Expression *expr)
1054 if (expr->isBinaryExpression()) {
1055 BinaryExpression *b = expr->toBinaryExpression();
1056 if (b->token() >= TOK_EQUALS && b->token() <= TOK_OR)
1058 } else if (expr->isUnaryExpression()) {
1059 UnaryExpression *u = expr->toUnaryExpression();
1060 if (u->token() == TOK_NOT)
1067 SemanticAnalysis::visitForTest(Expression *expr,
1072 Local<Type> boolType(zone_, zone_->types()->getPrimitive(PrimitiveType_Bool));
1074 TokenKind token = ToCompare(expr);
1075 if (token == TOK_EOF || token == TOK_NOT) {
1077 if (token == TOK_EOF)
1080 hir = eval(expr->toUnaryExpression()->expression());
1083 if ((hir = coerce(hir, boolType, Coerce_Arg)) == NULL)
1088 bool jumpOnTrue = (fallthrough == falseBranch) ^ (token == TOK_NOT);
1089 Opcode op = jumpOnTrue ? OP_JT : OP_JF;
1091 if (fallthrough == falseBranch)
1092 __ j(op, trueBranch);
1094 __ j(op, falseBranch);
1098 BinaryExpression *bin = expr->toBinaryExpression();
1099 if (token == TOK_AND || token == TOK_OR) {
1101 //visitForLogicTest(expr, trueBranch, falseBranch, fallthrough);
1105 HIR *left = eval(bin->left());
1106 HIR *right = eval(bin->right());
1107 if (!left || !right)
1110 HIR *hir = binary(bin, bin->token(), left, right);
1113 if ((hir = coerce(hir, boolType, Coerce_Arg)) == NULL)
1117 if (fallthrough == trueBranch)
1118 __ j(OP_JF, falseBranch);
1120 __ j(OP_JT, trueBranch);
1124 SemanticAnalysis::lvalue(Expression *expr)
1126 HIR *hir = eval(expr);
1130 if (!hir->isLValue()) {
1131 cc_.reportError(expr->pos(), Message_ExpectedLValue);
1135 return static_cast<HLValue *>(hir);
1139 SemanticAnalysis::eval(Expression *expr)
1151 SemanticAnalysis::discharge(HIR *hir)
1153 EmitHIR(zone_, emitter_, hir);